Add static-check gate (syntax + yamllint + ansible-lint) on PRs and deploy #1

Merged

kglitchy merged 1 commit from ci/static-check-gate into main 2026-06-05 18:11:06 +00:00

Conversation 2 Commits 1 Files changed 9 +167 -12

kglitchy commented 2026-06-05 18:09:43 +00:00

Owner

Copy link

Introduce just check running ansible-playbook --syntax-check, yamllint, and
ansible-lint, and a reusable Tekton ansible-check task that runs it. The new
PR PipelineRun (test.yaml) runs it on every pull request, and the deploy
pipeline now runs it before deploy-site, so the same checks gate every change.

Config:

• .yamllint: max line length 120, kept compatible with ansible-lint's bundled
  yamllint requirements; ignores the encrypted vault and vendored stickerpicker.
• .ansible-lint: excludes .tekton (k8s manifests), vendored files, and vault;
  temporarily skips var-naming[no-role-prefix] until server_config is split into
  per-component roles.

Fixes surfaced by the linters:

• defaults: fold long tuwunel image expr, derive coturn_cert_dir from
  caddy_data_dir, add element_release_base, lift an overlong comment.
• element: fold the version fact, build the tarball URL from element_release_base.
• stickerpicker: yes -> true; ansible.builtin.synchronize -> ansible.posix.
• deploy.yaml: defaultMode 0440 -> 288 (avoid implicit-octal ambiguity).

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

Introduce `just check` running ansible-playbook --syntax-check, yamllint, and ansible-lint, and a reusable Tekton `ansible-check` task that runs it. The new PR PipelineRun (test.yaml) runs it on every pull request, and the deploy pipeline now runs it before deploy-site, so the same checks gate every change. Config: - .yamllint: max line length 120, kept compatible with ansible-lint's bundled yamllint requirements; ignores the encrypted vault and vendored stickerpicker. - .ansible-lint: excludes .tekton (k8s manifests), vendored files, and vault; temporarily skips var-naming[no-role-prefix] until server_config is split into per-component roles. Fixes surfaced by the linters: - defaults: fold long tuwunel image expr, derive coturn_cert_dir from caddy_data_dir, add element_release_base, lift an overlong comment. - element: fold the version fact, build the tarball URL from element_release_base. - stickerpicker: yes -> true; ansible.builtin.synchronize -> ansible.posix. - deploy.yaml: defaultMode 0440 -> 288 (avoid implicit-octal ambiguity). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

kglitchy added 1 commit 2026-06-05 18:09:43 +00:00

Add static-check gate (syntax + yamllint + ansible-lint) on PRs and deploy ... a2ecbb698c

Introduce `just check` running ansible-playbook --syntax-check, yamllint, and
ansible-lint, and a reusable Tekton `ansible-check` task that runs it. The new
PR PipelineRun (test.yaml) runs it on every pull request, and the deploy
pipeline now runs it before deploy-site, so the same checks gate every change.

Config:
- .yamllint: max line length 120, kept compatible with ansible-lint's bundled
  yamllint requirements; ignores the encrypted vault and vendored stickerpicker.
- .ansible-lint: excludes .tekton (k8s manifests), vendored files, and vault;
  temporarily skips var-naming[no-role-prefix] until server_config is split into
  per-component roles.

Fixes surfaced by the linters:
- defaults: fold long tuwunel image expr, derive coturn_cert_dir from
  caddy_data_dir, add element_release_base, lift an overlong comment.
- element: fold the version fact, build the tarball URL from element_release_base.
- stickerpicker: yes -> true; ansible.builtin.synchronize -> ansible.posix.
- deploy.yaml: defaultMode 0440 -> 288 (avoid implicit-octal ambiguity).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

kglitchy commented 2026-06-05 18:09:45 +00:00

Author

Owner

Copy link

Pipelines as Code CI/glitches-chat-test-dghz2 is running.

Starting Pipelinerun glitches-chat-test-dghz2 in namespace glitches-chat-pipelines

You can monitor the execution using the Tekton Dashboard PipelineRun viewer or through the command line by
using the tkn CLI with the following command:

tkn pr logs -n glitches-chat-pipelines glitches-chat-test-dghz2 -f

Pipelines as Code CI/glitches-chat-test-dghz2 is running. Starting Pipelinerun <b>[glitches-chat-test-dghz2](https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns/glitches-chat-test-dghz2)</b> in namespace <b>glitches-chat-pipelines</b> You can monitor the execution using the [Tekton Dashboard](https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns/glitches-chat-test-dghz2) PipelineRun viewer or through the command line by using the [tkn](https://tekton.dev/docs/cli/#installation) CLI with the following command: <code>tkn pr logs -n glitches-chat-pipelines glitches-chat-test-dghz2 -f</code>

kglitchy commented 2026-06-05 18:10:48 +00:00

Author

Owner

Copy link

Pipelines as Code CI/glitches-chat-test-dghz2 has successfully validated your commit.

• Namespace: glitches-chat-pipelines
• PipelineRun: glitches-chat-test-dghz2

---

Task Statuses:

Status	Duration	Name
Succeeded	25 seconds	fetch-repository
Succeeded	38 seconds	Static checks

Pipelines as Code CI/glitches-chat-test-dghz2 has <b>successfully</b> validated your commit. <ul> <li><b>Namespace</b>: <a href="https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns">glitches-chat-pipelines</a></li> <li><b>PipelineRun:</b> <a href="https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns/glitches-chat-test-dghz2">glitches-chat-test-dghz2</a></li> </ul> <hr> <h4>Task Statuses:</h4> <table> <tr><th>Status</th><th>Duration</th><th>Name</th></tr> <tr> <td>Succeeded</td> <td>25 seconds</td><td> [fetch-repository](https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns/glitches-chat-test-dghz2?pipelineTask=fetch-repository) </td></tr> <tr> <td>Succeeded</td> <td>38 seconds</td><td> [Static checks](https://tekton.corp.mulliken.net/#/namespaces/glitches-chat-pipelines/pipelineruns/glitches-chat-test-dghz2?pipelineTask=check) </td></tr> </table>

kglitchy merged commit 8873626a01 into main 2026-06-05 18:11:06 +00:00

kglitchy referenced this pull request from a commit 2026-06-05 18:11:08 +00:00

Merge pull request 'Add static-check gate (syntax + yamllint + ansible-lint) on PRs and deploy' (#1) from ci/static-check-gate into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kglitchy/glitches.chat!1

No description provided.