Apply legacy Tombstone items when replaying state #2

Merged

kglitchy merged 3 commits from kglitchy/legacy-tombstone into main

2026-09-28 21:43:07 +00:00

AGit

kglitchy commented

2026-09-28 21:40:57 +00:00

Owner

Older Things Cloud histories record deletions as plain Tombstone items (82 in my history, all from 2019–2020). Replay only handled Tombstone2, so a deletion stored in the legacy kind never removed its object from local state.

Changes

Add ItemKindTombstonePlain ("Tombstone") and replay it the same way as Tombstone2. Both kinds share the same payload shape (dloid, dld), verified against raw history.
Writes still emit Tombstone2.
Add TestStateReplayAppliesLegacyTombstones (fails without the fix, passes with it).

Verification

go test ./... passes; gofmt and go vet are clean.
Fresh-cache replay of my real history before and after: 3,696 tasks, 478 checklist items, 5 areas, and 23 tags in both. None of the legacy-deleted objects are present in current state, so this is a correctness fix for older histories with no visible change here.

Independent of #1 (Task7); either can merge first.

Older Things Cloud histories record deletions as plain `Tombstone` items (82 in my history, all from 2019–2020). Replay only handled `Tombstone2`, so a deletion stored in the legacy kind never removed its object from local state. ## Changes - Add `ItemKindTombstonePlain` (`"Tombstone"`) and replay it the same way as `Tombstone2`. Both kinds share the same payload shape (`dloid`, `dld`), verified against raw history. - Writes still emit `Tombstone2`. - Add `TestStateReplayAppliesLegacyTombstones` (fails without the fix, passes with it). ## Verification - `go test ./...` passes; `gofmt` and `go vet` are clean. - Fresh-cache replay of my real history before and after: 3,696 tasks, 478 checklist items, 5 areas, and 23 tags in both. None of the legacy-deleted objects are present in current state, so this is a correctness fix for older histories with no visible change here. Independent of #1 (Task7); either can merge first.

kglitchy added 1 commit

2026-09-28 21:40:57 +00:00

Apply legacy Tombstone items when replaying state 50dd20ed4b

Older Things Cloud histories record deletions as plain Tombstone items.
Replay only handled Tombstone2, so a deletion stored in the legacy kind
never removed its object from local state. The payload shape (dloid,
dld) is the same, so handle both kinds alike. Writes still emit
Tombstone2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kglitchy force-pushed kglitchy/legacy-tombstone from 50dd20ed4b to 3701dba082

2026-09-28 21:41:20 +00:00

Compare

kglitchy force-pushed kglitchy/legacy-tombstone from 3701dba082 to 971b399598

2026-09-28 21:43:07 +00:00

Compare

kglitchy merged commit 94e5a358de into main

2026-09-28 21:43:07 +00:00

kglitchy referenced this pull request from a commit

2026-09-28 21:43:08 +00:00

Merge pull request 'Apply legacy Tombstone items when replaying state' (#2) from kglitchy/legacy-tombstone into main